Set ConnectionManager as global in Container#53
Open
MWhite-22 wants to merge 1 commit intotypestack:masterfrom
Open
Set ConnectionManager as global in Container#53MWhite-22 wants to merge 1 commit intotypestack:masterfrom
MWhite-22 wants to merge 1 commit intotypestack:masterfrom
Conversation
Fixes scoped containerInstance.get requests for ConnectionManager, which was previously creating a cloned ConnectionManager via new ConnectionManager(), thereby removing all prior connection information.
Author
|
Checking in on any sort of acknowledgement here from any maintainers. It’s only a single line change in the package. Detailed comments are in #51 |
Contributor
|
I'm not a maintainer. |
Author
|
Checking in again. |
Author
|
I hate to keep pinging you both, but when trying to dockerize, the non-global container issue is a real bummer. |
|
@NoNameProvided any chance to approve and release a new patch for this package? Without it it breaks scoped comtainers. |
Author
|
bumping this again |
Author
|
Bumping this to the top of (hopefully) someones review queue |
Author
|
Welp, about time to bump this one up again... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes scoped containerInstance.get requests for ConnectionManager, which was previously creating a cloned ConnectionManager via new ConnectionManager(), thereby removing all prior connection information.